Skip to content

Make multipart and websocket support optional, but supported by default#264

Merged
seanmonstar merged 3 commits intoseanmonstar:masterfrom
SimonSapin:optional
Aug 16, 2019
Merged

Make multipart and websocket support optional, but supported by default#264
seanmonstar merged 3 commits intoseanmonstar:masterfrom
SimonSapin:optional

Conversation

@SimonSapin
Copy link
Copy Markdown
Contributor

No description provided.

@SimonSapin
Copy link
Copy Markdown
Contributor Author

This avoids depending (through multipart) on old versions of mime, mime_guess, and log which duplicate with more recent versions that are also used. Per abonander/multipart#121 it looks like multipart wants to support an old version of rustc, and so may not be open to updating its dependencies.

@seanmonstar
Copy link
Copy Markdown
Owner

I'm good with this! Thanks!

@seanmonstar seanmonstar merged commit c605336 into seanmonstar:master Aug 16, 2019
@SimonSapin SimonSapin deleted the optional branch August 16, 2019 16:27
@SimonSapin
Copy link
Copy Markdown
Contributor Author

Nice! Could you publish on crates.io?

@seanmonstar
Copy link
Copy Markdown
Owner

@SimonSapin sure! While I'm getting ready, there's nothing else that needs de-duping, right?

@SimonSapin
Copy link
Copy Markdown
Contributor Author

I tried it with [patch.crates-io] on mozilla-central and I think this is it, thanks!

@seanmonstar
Copy link
Copy Markdown
Owner

Published!

@abonander
Copy link
Copy Markdown

@SimonSapin I don't care so much about old Rust support but I figured breaking on Debian-stretch might be an issue for Servo/Firefox.

@SimonSapin
Copy link
Copy Markdown
Contributor Author

Firefox generally bumps its Rust version requirement to the latest Stable two weeks after that release: https://wiki.mozilla.org/Rust_Update_Policy_for_Firefox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants