Skip to content

fix unsound use of pointer::add #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seanmonstar merged 1 commit into from
Sep 30, 2024
Merged

fix unsound use of pointer::add #185

seanmonstar merged 1 commit into from
Sep 30, 2024
+1 −1

Conversation

@krasimirgg
Copy link
Contributor

@krasimirgg krasimirgg commented Sep 25, 2024 •
edited
Loading

No functional changes intended.

From the docs of pointer::add:

If the computed offset is non-zero, then self must be derived from a pointer to some allocated object, and the entire memory range between self and the result must be in bounds of that allocated object. In particular, this range must not “wrap around” the edge of the address space.

@seanmonstar
Copy link
Owner

seanmonstar commented Sep 25, 2024

Thanks! Notably, this was reported in #177.

Thoughts @AaronO?

@seanmonstar seanmonstar merged commit cf69365 into seanmonstar:master Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krasimirgg @seanmonstar