Improve request method parsing #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Special-case parsing of the GET request method as that is by far the
most common. Speeds up the req_short benchmark by a fair margin:
req_short/req_short time: [32.601 ns 32.737 ns 32.914 ns]
thrpt: [1.9241 GiB/s 1.9345 GiB/s 1.9425 GiB/s]
change:
time: [-4.1113% -3.5415% -3.0150%] (p = 0.00 < 0.05)
thrpt: [+3.1087% +3.6715% +4.2876%]
Performance has improved.
Co-authored-by: Luca Casonato <hello@lcas.dev>
Owner
|
Thanks! Should I assume this supercedes #118? |
Contributor
Author
|
Something like that yeah 😁 |
seanmonstar
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special-case parsing of the GET request method as that is by far the
most common. Speeds up the req_short benchmark by a fair margin:
Co-authored-by: Luca Casonato hello@lcas.dev