Add UserAgent for all chats httpclient usage

sdcb · sdcb · commit 1118da34ff47 · 2025-12-19T18:27:50.000+08:00
diff --git a/src/BE/Controllers/Admin/GlobalConfigs/GitHubReleaseChecker.cs b/src/BE/Controllers/Admin/GlobalConfigs/GitHubReleaseChecker.cs
@@ -3,27 +3,15 @@
 
 namespace Chats.BE.Controllers.Admin.GlobalConfigs;
 
-public class GitHubReleaseChecker
+public class GitHubReleaseChecker(IHttpClientFactory httpClientFactory)
 {
-    private readonly HttpClient _httpClient;
-    private readonly string _owner;
-    private readonly string _repo;
-
-    public static GitHubReleaseChecker SdcbChats => new("sdcb", "chats");
-
-    public GitHubReleaseChecker(string owner, string repo)
-    {
-        _owner = owner;
-        _repo = repo;
-
-        _httpClient = new HttpClient { BaseAddress = new Uri("https://api.github.com") };
-        _httpClient.DefaultRequestHeaders.UserAgent.Add(new ProductInfoHeaderValue("SdcbChatsVersionChecker", "1.0"));
-        _httpClient.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/vnd.github.v3+json"));
-    }
-
     public async Task<string> GetLatestReleaseTagNameAsync(CancellationToken cancellationToken)
     {
-        HttpResponseMessage response = await _httpClient.GetAsync($"/repos/{_owner}/{_repo}/releases/latest", cancellationToken);
+        using HttpClient httpClient = httpClientFactory.CreateClient();
+        httpClient.BaseAddress = new Uri("https://api.github.com");
+        httpClient.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/vnd.github.v3+json"));
+
+        HttpResponseMessage response = await httpClient.GetAsync($"/repos/sdcb/chats/releases/latest", cancellationToken);
         response.EnsureSuccessStatusCode(); // 如果请求失败，抛出异常
 
         using Stream responseStream = await response.Content.ReadAsStreamAsync(cancellationToken);
diff --git a/src/BE/Controllers/Admin/GlobalConfigs/VersionController.cs b/src/BE/Controllers/Admin/GlobalConfigs/VersionController.cs
@@ -20,13 +20,13 @@ public ActionResult<string> GetCurrentVersion()
 
     [HttpPost("check-update")]
     public async Task<ActionResult<CheckUpdateResponse>> CheckUpdate(
-        [FromServices] ILogger<VersionController> logger,
+        [FromServices] GitHubReleaseChecker gitHubReleaseChecker,
         CancellationToken cancellationToken)
     {
         string? tagName = null;
         try
         {
-            tagName = await GitHubReleaseChecker.SdcbChats.GetLatestReleaseTagNameAsync(cancellationToken);
+            tagName = await gitHubReleaseChecker.GetLatestReleaseTagNameAsync(cancellationToken);
         }
         catch (Exception e)
         {
diff --git a/src/BE/Program.cs b/src/BE/Program.cs
@@ -10,17 +10,23 @@
 using Chats.BE.Services.Security;
 using Microsoft.AspNetCore.Authentication;
 using Microsoft.AspNetCore.Mvc;
+using System.Reflection;
 using System.Runtime.CompilerServices;
 using Chats.BE.Services.FileServices;
 using Microsoft.AspNetCore.StaticFiles;
 using Chats.BE.Services.Models.ChatServices;
+using Chats.BE.Controllers.Admin.GlobalConfigs;
 
 [assembly: InternalsVisibleTo("Chats.BE.Tests")]
 
 namespace Chats.BE;
 
 public class Program
 {
+    private static string? CurrentVersion => typeof(Program).Assembly
+        .GetCustomAttribute<AssemblyFileVersionAttribute>()?
+        .Version;
+
     public static async Task Main(string[] args)
     {
         WebApplicationBuilder builder = WebApplication.CreateBuilder(args);
@@ -38,7 +44,10 @@ public static async Task Main(string[] args)
         builder.Services.AddEndpointsApiExplorer();
         builder.Services.AddSwaggerGen();
         builder.Services.AddDbContext<ChatsDB>(o => o.Configure(builder.Configuration, builder.Environment));
-        builder.Services.AddHttpClient();
+        builder.Services.AddHttpClient(string.Empty, httpClient =>
+        {
+            httpClient.DefaultRequestHeaders.UserAgent.ParseAdd($"Sdcb-Chats/{CurrentVersion}");
+        });
         builder.Services.AddSingleton<InitService>();
         builder.Services.AddSingleton<AppConfigService>();
         builder.Services.AddSingleton<CsrfTokenService>();
@@ -77,6 +86,7 @@ public static async Task Main(string[] args)
         builder.Services.AddSingleton<FileImageInfoService>();
         builder.Services.AddSingleton<AsyncClientInfoManager>();
         builder.Services.AddSingleton<AsyncCacheUsageManager>();
+        builder.Services.AddSingleton<GitHubReleaseChecker>();
 
         builder.Services.AddScoped<CurrentUser>();
         builder.Services.AddScoped<CurrentApiKey>();

Original file line number	Diff line number	Diff line change
`@@ -20,13 +20,13 @@ public ActionResult<string> GetCurrentVersion()`
`20`	`20`
`21`	`21`	`[HttpPost("check-update")]`
`22`	`22`	`public async Task<ActionResult<CheckUpdateResponse>> CheckUpdate(`
`23`		`- [FromServices] ILogger<VersionController> logger,`
	`23`	`+ [FromServices] GitHubReleaseChecker gitHubReleaseChecker,`
`24`	`24`	`CancellationToken cancellationToken)`
`25`	`25`	`{`
`26`	`26`	`string? tagName = null;`
`27`	`27`	`try`
`28`	`28`	`{`
`29`		`- tagName = await GitHubReleaseChecker.SdcbChats.GetLatestReleaseTagNameAsync(cancellationToken);`
	`29`	`+ tagName = await gitHubReleaseChecker.GetLatestReleaseTagNameAsync(cancellationToken);`
`30`	`30`	`}`
`31`	`31`	`catch (Exception e)`
`32`	`32`	`{`