fix(RequestTraceHelper): update MatchesPatterns to handle empty patterns result

sdcb · sdcb · commit 0636c7a57c13 · 2026-02-24T18:59:34.000+08:00
diff --git a/src/BE/web/Services/RequestTracing/RequestTraceHelper.cs b/src/BE/web/Services/RequestTracing/RequestTraceHelper.cs
@@ -22,7 +22,7 @@ public static bool MatchFilters(RequestTraceFilters filters, string? source, str
     {
         if (!MatchesPatterns(source, filters.SourcePatterns)) return false;
         if (!MatchesPatterns(url, filters.IncludeUrlPatterns)) return false;
-        if (MatchesPatterns(url, filters.ExcludeUrlPatterns)) return false;
+        if (MatchesPatterns(url, filters.ExcludeUrlPatterns, emptyPatternsResult: false)) return false;
 
         if (filters.Methods is { Length: > 0 } && !filters.Methods.Any(x => string.Equals(x, method, StringComparison.OrdinalIgnoreCase)))
         {
@@ -112,7 +112,7 @@ public static bool MatchRequestStageFilters(RequestTraceFilters filters, string?
     {
         if (!MatchesPatterns(source, filters.SourcePatterns)) return false;
         if (!MatchesPatterns(url, filters.IncludeUrlPatterns)) return false;
-        if (MatchesPatterns(url, filters.ExcludeUrlPatterns)) return false;
+        if (MatchesPatterns(url, filters.ExcludeUrlPatterns, emptyPatternsResult: false)) return false;
         if (filters.Methods is { Length: > 0 } && !filters.Methods.Any(x => string.Equals(x, method, StringComparison.OrdinalIgnoreCase)))
         {
             return false;
@@ -160,11 +160,11 @@ private static bool MatchStatus(short code, string[] patterns)
         return false;
     }
 
-    private static bool MatchesPatterns(string? value, string[]? patterns)
+    private static bool MatchesPatterns(string? value, string[]? patterns, bool emptyPatternsResult = true)
     {
         if (patterns == null || patterns.Length == 0)
         {
-            return true;
+            return emptyPatternsResult;
         }
 
         if (string.IsNullOrEmpty(value))

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public static bool MatchFilters(RequestTraceFilters filters, string? source, str`
`22`	`22`	`{`
`23`	`23`	`if (!MatchesPatterns(source, filters.SourcePatterns)) return false;`
`24`	`24`	`if (!MatchesPatterns(url, filters.IncludeUrlPatterns)) return false;`
`25`		`- if (MatchesPatterns(url, filters.ExcludeUrlPatterns)) return false;`
	`25`	`+ if (MatchesPatterns(url, filters.ExcludeUrlPatterns, emptyPatternsResult: false)) return false;`
`26`	`26`
`27`	`27`	`if (filters.Methods is { Length: > 0 } && !filters.Methods.Any(x => string.Equals(x, method, StringComparison.OrdinalIgnoreCase)))`
`28`	`28`	`{`
`@@ -112,7 +112,7 @@ public static bool MatchRequestStageFilters(RequestTraceFilters filters, string?`
`112`	`112`	`{`
`113`	`113`	`if (!MatchesPatterns(source, filters.SourcePatterns)) return false;`
`114`	`114`	`if (!MatchesPatterns(url, filters.IncludeUrlPatterns)) return false;`
`115`		`- if (MatchesPatterns(url, filters.ExcludeUrlPatterns)) return false;`
	`115`	`+ if (MatchesPatterns(url, filters.ExcludeUrlPatterns, emptyPatternsResult: false)) return false;`
`116`	`116`	`if (filters.Methods is { Length: > 0 } && !filters.Methods.Any(x => string.Equals(x, method, StringComparison.OrdinalIgnoreCase)))`
`117`	`117`	`{`
`118`	`118`	`return false;`
`@@ -160,11 +160,11 @@ private static bool MatchStatus(short code, string[] patterns)`
`160`	`160`	`return false;`
`161`	`161`	`}`
`162`	`162`
`163`		`- private static bool MatchesPatterns(string? value, string[]? patterns)`
	`163`	`+ private static bool MatchesPatterns(string? value, string[]? patterns, bool emptyPatternsResult = true)`
`164`	`164`	`{`
`165`	`165`	`if (patterns == null \|\| patterns.Length == 0)`
`166`	`166`	`{`
`167`		`- return true;`
	`167`	`+ return emptyPatternsResult;`
`168`	`168`	`}`
`169`	`169`
`170`	`170`	`if (string.IsNullOrEmpty(value))`