Skip to content

Don't SetLatency() when it won't change the latency. #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sdatkinson merged 2 commits into from
Oct 30, 2024
Merged

Don't SetLatency() when it won't change the latency. #516

sdatkinson merged 2 commits into from
Oct 30, 2024

Conversation

@sdatkinson
Copy link
Owner

@sdatkinson sdatkinson commented Oct 30, 2024 •
edited
Loading

Description

During _UpdateLatency(), Only SetLatency(latency) when latency != GetLatency().

It feels weird to have to do this but it works.

Resolves #507

PR Checklist

  • Does the VST3 plugin pass all of the unit tests in the VST3PluginTestHost? (Download it as part of the VST3 SDK here.)
    • Windows
    • macOS
  • [N] Does your PR add, remove, or rename any plugin parameters?
    • [N/A] If yes, then have you ensured that older versions of the plug-in load correctly?

@sdatkinson sdatkinson merged commit 6466123 into main Oct 30, 2024
@sdatkinson sdatkinson deleted the 507-cubase branch October 30, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Plugin Version 0.7.10 - Audio is choppy/glitchy in Cubase

2 participants

@sdatkinson