Skip to content

[ENHANCEMENT] Support for different sample rates #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sdatkinson merged 16 commits into from
Dec 4, 2023
Merged

[ENHANCEMENT] Support for different sample rates #397

sdatkinson merged 16 commits into from
Dec 4, 2023

Conversation

@sdatkinson
Copy link
Owner

@sdatkinson sdatkinson commented Dec 4, 2023

The incoming audio is now correctly resampled to what is expected by the NAM models.

Resolves #59

sdatkinson added 16 commits June 22, 2023 18:29
@sdatkinson
Update on core, NAM models expose expected sample rates
cc4b669
@sdatkinson
Merge branch 'main' of https://github.com/sdatkinson/NeuralAmpModeler…
f2739e0 
…Plugin into issue-59
@sdatkinson
Add resample files to XCode project
3b825d3
@sdatkinson
Implement structure of the resampler. Dummy algorithm in place
8ab5bf7
@sdatkinson
Implement placeholder for finalize_()
39d0679
@sdatkinson
Implement dummy resampling that transfers data to encapsulated buffer…
f0af187 
… arrays.
@sdatkinson
Rearrange files
77ece11
@sdatkinson
Merge branch 't' into issue-59
c579565
@sdatkinson
Merge branch 'issue-59' of https://github.com/sdatkinson/NeuralAmpMod…
9fb6aa3 
…elerPlugin into issue-59
@sdatkinson
Format
940cf58
@sdatkinson
Update iPlug2
1b610f7
@sdatkinson
Implement resampling using iPlug2 tools
860101d
@sdatkinson
Fix XCode project
b8ea3c3
@sdatkinson
Format
fb16a89
@sdatkinson
Fix iPlug2 commit, add aax and app filters to VS solution
e053511
@sdatkinson
Update core
dcb5162
@sdatkinson
Copy link
Owner Author

sdatkinson commented Dec 4, 2023

🤞🏻

@sdatkinson sdatkinson merged commit 13f066e into main Dec 4, 2023
@sdatkinson sdatkinson deleted the issue-59 branch December 4, 2023 03:24
@DivannKokos
Copy link

DivannKokos commented Dec 4, 2023

yay, finally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Support for other plugin sample rates

3 participants

@sdatkinson @DivannKokos