Skip to content

Plugin version 0.7.12 causes Nembrini Nexus host to crash (exit unexpectedly). And proposed solution inside.  #541

@synchu

Description

@synchu

Once the plugin (0.7.12) is added and you try to open it, Nexus crashes and exits unexpectedly.

To reproduce

Steps to reproduce the behavior:

  1. Open Nexus
  2. Add NAM 0.7.12
  3. Double click on the plugin box to open the plugin UI
  4. Nexus crashes and exits (even without error)

Expected behavior

Plugin GUI opens.

Screenshots

N/A

Computer & other info

(please provide the following information):

  • OS Windows 11
  • NVidia RTX 2060 Super
  • Plugin version - 0.7.12
  • VST3
  • Nexus plugin host
  • RME RayDat
  • 48Khz
  • 128
  • N/A
  • N/A

Additional context

The bug is caused potentially by Nexus handling of plugin UI refresh, caused by "endless" loop (initially caused by calling OnTextEntryCompletion, see the Call Stack dump attached - SetParamNormalized <-> performEdit loop):
NeuralAmpModelerControls.h
void SetValueFromDelegate(double normalizedValue, int valIdx) override
{
IControl::SetValueFromDelegate(normalizedValue, valIdx);
const std::string s = ConvertToString(normalizedValue);
-->>> OnTextEntryCompletion(s.c_str(), valIdx); <<<---
};

if this is changed to (which seems to make more sense):

void SetValueFromDelegate(double normalizedValue, int valIdx) override
{
IControl::SetValueFromDelegate(normalizedValue, valIdx);
const std::string s = ConvertToString(normalizedValue);
SetStr(s.c_str());
};

The problem is solved.

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpriority:lowLow priority issues

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions