Cleanup tablets code #583
Merged
Cleanup tablets code #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unused and not going to be used, only occupy memory and eats CPU on hash calculation
Keyspace and table name are not used. It only occupie memory and CPU on hash calculation. At not point tablet from one table/keyspace is compared to a tablet from another table/keyspace.
Purely cosmetic, it is not used anywhere.
Second .get on mapping is not necessary.
Bouncheck
approved these changes
Aug 18, 2025
Bouncheck
left a comment
There was a problem hiding this comment.
LGTM, although my IDE for some reason cannot find usages of toString properly and highlights a bunch of unrelated function calls.
If there are any just note that the keyspace will not be logged anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleanups tablets code to reduce tablet memory and CPU footprint.
And couple of nearly cosmetic changes.