Skip to content

3.x: Update github ubuntu runner #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkropachev merged 2 commits into from
Mar 10, 2025
Merged

3.x: Update github ubuntu runner #455

dkropachev merged 2 commits into from
Mar 10, 2025

Conversation

@dkropachev
Copy link

@dkropachev dkropachev commented Mar 6, 2025 •
edited
Loading

Image going to be depricated at 2025.04.01,
actions/runner-images#11101.

This PR does:

  1. Moves runners to ubuntu-latest
  2. Switches from netty-tcnative to netty-tcnative-boringssl-static due to problems of getting old libssl.so.1.0.0 installed on modern distros.
  3. Updates netty

@dkropachev dkropachev self-assigned this Mar 6, 2025
@dkropachev dkropachev force-pushed the dk/update-github-runners branch 4 times, most recently from 425afb9 to c2d7305 Compare March 6, 2025 17:01
@dkropachev dkropachev changed the title 3.x: Update github ubuntu runner from 20.04 to 24.04 3.x: Update github ubuntu runner Mar 6, 2025
@dkropachev dkropachev force-pushed the dk/update-github-runners branch 3 times, most recently from 0c22bdb to a22e381 Compare March 7, 2025 16:54
@dkropachev
Update github ubuntu runner
b19c417 
Image going to be depricated at 2025.04.01,
actions/runner-images#11101.
@dkropachev
Move to netty-tcnative-boringss-static
149aaba 
netty-tcnative depends on dynamic libssl.so.1.0.0, which is problematic
to get installed on modern distros.
At the same time, boringssl-static is a build-in lib that does not have
dependancies.
And it is slightly faster than openssl 1 and 3.

Also updating netty package.
@dkropachev dkropachev force-pushed the dk/update-github-runners branch from 0cd680e to 149aaba Compare March 8, 2025 04:46
@dkropachev dkropachev requested a review from Bouncheck March 8, 2025 04:50
Bouncheck
Bouncheck reviewed Mar 10, 2025
View reviewed changes
Copy link

@Bouncheck Bouncheck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd lock the ubuntu version but this is fine too.
Why is the libssl 1.0.0 necessary? Does the driver not run with the version that is there available?
I don't know if changing to a different (and static) ssl library is a good idea here, I trust you on that.

@dkropachev dkropachev requested a review from Bouncheck March 10, 2025 10:45
@Bouncheck
Copy link

Bouncheck commented Mar 10, 2025

Why is the libssl 1.0.0 necessary? Does the driver not run with the version that is there available?

This was not answered. Wouldn't it be better to leave OpenSSL dependent libraries and just use newer version on the runners?

@dkropachev
Copy link
Author

dkropachev commented Mar 10, 2025 •
edited
Loading

Why is the libssl 1.0.0 necessary? Does the driver not run with the version that is there available?

This was not answered. Wouldn't it be better to leave OpenSSL dependent libraries and just use newer version on the runners?

It is necessary to make SSL work, as i have mentioned in commit message netty-tcnative REQUIRES libssl.so.1.0.0, it does not even support libssl.so.1.1.x.

@dkropachev dkropachev merged commit 63a9828 into scylla-3.x Mar 10, 2025
11 checks passed
@Bouncheck Bouncheck mentioned this pull request Mar 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Bouncheck Bouncheck Bouncheck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dkropachev dkropachev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dkropachev @Bouncheck