Conversation
15fd950 to
8a01c00
Compare
engines/petka/metaengine.cpp
Outdated
| act->addDefaultInputMapping("JOY_B"); | ||
| engineKeymap->addAction(act); | ||
|
|
||
| act = new Action("LOOK", _("Switch cursor to 'look'")); |
There was a problem hiding this comment.
Unless you used this same wording in other engines, I’d recommend renaming this action to simple “Look”. Same for other places
engines/petka/metaengine.cpp
Outdated
| act->addDefaultInputMapping("JOY_RIGHT_TRIGGER"); | ||
| engineKeymap->addAction(act); | ||
|
|
||
| act = new Action("INVENTORY", _("Toggle inventory")); |
There was a problem hiding this comment.
What does “toggle” mean here? Either use better wording or add a note to translators
There was a problem hiding this comment.
"toggle" here means you can open and close the inventory by pressing the same key. would "Show / hide inventory" be a better description?
There was a problem hiding this comment.
Check the similar actions in other engines, how are they described there?
engines/petka/metaengine.cpp
Outdated
| act->addDefaultInputMapping("JOY_RIGHT_SHOULDER"); | ||
| engineKeymap->addAction(act); | ||
|
|
||
| act = new Action("OPTIONS", _("Toggle options screen")); |
There was a problem hiding this comment.
"toggle" here means you can open and close the options screeen by pressing the same key. would "Show / hide options screen" be a better description or simply "Options"?
engines/petka/metaengine.cpp
Outdated
| act->addDefaultInputMapping("F3"); | ||
| engineKeymap->addAction(act); | ||
|
|
||
| act = new Action("FIXCURSOR", _("Fix cursor")); |
There was a problem hiding this comment.
What does fixing mean in this context? Explanation to the translators is required
There was a problem hiding this comment.
During my testing, I did not have any issues with the cursor. Hence, i'm not sure what issue occurs.
However, There is a comment in the code regarding this and the function called seems to make the cursor draw again:
scummvm/engines/petka/q_system.cpp
Line 428 in 555b4cd
8a01c00 to
773f855
Compare
|
Thank you! |
No description provided.