Skip to content

LAB: Add keymapper support#6849

Merged
sev- merged 1 commit intoscummvm:masterfrom
aunnoman1:lab-keymapper
Aug 18, 2025
Merged

LAB: Add keymapper support#6849
sev- merged 1 commit intoscummvm:masterfrom
aunnoman1:lab-keymapper

Conversation

@aunnoman1
Copy link
Contributor

No description provided.

@sev- sev- added the GSoC Part of a Google Summer of Code project label Aug 2, 2025
act->setCustomEngineActionEvent(kActionQuit);
act->addDefaultInputMapping("q");
act->addDefaultInputMapping("x");
act->addDefaultInputMapping("JOY_DOWN");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might recommend removing this default if quit can be selected with a left click somewhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only way to access the quit dialog is through this action i.e not possible with left click

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify your response. It is not clear to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant is that the quit dialog is only accessible through this specific action( by pressing the keys "q", "x" or button "joy_down" in the default keymapper settings).

there is no button or UI element that can be clicked with the mouse left button to access the quit dialog.

Copy link
Member

@OMGPizzaGuy OMGPizzaGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - might want to consider my note on the quit action default map to joy down

@sev-
Copy link
Member

sev- commented Aug 18, 2025

Thank you!

@sev- sev- merged commit 41a95cd into scummvm:master Aug 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSoC Part of a Google Summer of Code project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants