Merged
Conversation
sev-
reviewed
Aug 9, 2025
Member
sev-
left a comment
There was a problem hiding this comment.
I started to review, but quickly faced with abundant amount of added magic numbers. Is there a way to improve how we handle these indices, so it is clearer to the developers what is going on?
| r.translate(0, 25); | ||
| } else { | ||
| addButton(Common::Rect(), Common::KEYCODE_INVALID); | ||
| addButton(Common::Rect(), Common::KEYCODE_INVALID, nullptr, 1); |
Member
There was a problem hiding this comment.
I am not a huge fan of magic numbers like this. Is there a way and sense in general, of putting these indexes to an enum?
| addButton(Common::Rect(285, 75, 309, 95), Res.KeyConstants.DialogsCharInfo.KEY_EXCHANGE, &_iconSprites); | ||
|
|
||
| addButton(Common::Rect(285, 107, 309, 127), Common::KEYCODE_ESCAPE, &_iconSprites); | ||
| addButton(Common::Rect(10, 24, 34, 44), 1001, &_iconSprites, 4); |
Member
There was a problem hiding this comment.
This code snippet (and other like this) are very clearly show the probem with these magic numbers. Why it is 4 and not, say, 28? If there would be some kind of an enum, that would make it less error-prone.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a toggle for text-to-speech to the game options.
Adds text-to-speech for the following:
Currently only tested with Xeen games. Only English, Russian, and Spanish translations have been tested.