Merged
Conversation
Member
|
Looks good to me, but let's wait for feedback from @Strangerke as well |
Member
|
I quickly reversed the code related to the first commit, could you test the suggested code I put? |
Member
I don't see your suggested code anywhere. Did you maybe add it as a review comment and then forgot to submit the review? |
Strangerke
requested changes
Jul 18, 2025
Member
Strangerke
left a comment
There was a problem hiding this comment.
Thanks for your pr and for noticing these issues. I added 2 code modifications based on the assembly
Member
|
Fine for me, thanks again! |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes what I think are a few issues that I encountered while working on text-to-speech: