Conversation
engines/prince/prince.h
Outdated
| kSecondHero | ||
| }; | ||
|
|
||
| bool _intro; |
There was a problem hiding this comment.
grouping the bool values would make the PrinceEngine a few bytes smaller.
|
|
||
| void PrinceEngine::stopTextToSpeech() const { | ||
| Common::TextToSpeechManager *ttsMan = g_system->getTextToSpeechManager(); | ||
| if (ttsMan != nullptr && (ConfMan.getBool("tts_enabled_objects") || ConfMan.getBool("tts_enabled_speech") || ConfMan.getBool("tts_enabled_missing_voice")) && |
There was a problem hiding this comment.
I am not sure about this one... What if the intro plays, you go into the scummvm options menu to disable the tts features - but the voice is still speaking (and the game continues after you've left the scummvm options menu)
There was a problem hiding this comment.
I might be misunderstanding, but I don't think the TTS features can be disabled using the ScummVM menu while in-game. The current implementation for this engine does stop voicing new text if the speech volume is set above 0, but this doesn't change the value of the tts_enabled bools, so this method would be unaffected. It also seems that opening the options menu immediately stops whatever TTS is speaking at the moment regardless.
engines/prince/prince.cpp
Outdated
| }; | ||
|
|
||
| struct CharacterVoiceData { | ||
| uint32 textColor; |
There was a problem hiding this comment.
I think this table could be reduced in size by using uint8, uint8, uint8, int8, bool
engines/prince/prince.cpp
Outdated
| }; | ||
|
|
||
| // Custom encoding | ||
| static const int germanEncodingTable[] = { |
There was a problem hiding this comment.
the encoding tables could be uint16 to reduce the size on some systems.
engines/prince/script.cpp
Outdated
| if (cursorId == 0) { | ||
| _vm->_isConversing = true; | ||
| } else if (cursorId == 1) { | ||
| _vm->_isConversing = false; | ||
| } |
There was a problem hiding this comment.
| if (cursorId == 0) { | |
| _vm->_isConversing = true; | |
| } else if (cursorId == 1) { | |
| _vm->_isConversing = false; | |
| } | |
| _vm->_isConversing = (cursorId == 0); |
engines/prince/prince.cpp
Outdated
| bool male; | ||
| }; | ||
|
|
||
| static const CharacterVoiceData characterVoiceDatas[] = { |
There was a problem hiding this comment.
| static const CharacterVoiceData characterVoiceDatas[] = { | |
| static const CharacterVoiceData characterVoiceData[] = { |
engines/prince/prince.cpp
Outdated
| { 217, 31, 0, -1, true } // Narrator | ||
| }; | ||
|
|
||
| static const int kNumberOfCharacterDatas = ARRAYSIZE(characterVoiceDatas); |
There was a problem hiding this comment.
| static const int kNumberOfCharacterDatas = ARRAYSIZE(characterVoiceDatas); | |
| static const int kCharacterVoiceDataCount = ARRAYSIZE(characterVoiceData); |
|
Thank you! |
Adds toggles for text-to-speech to the game options.
Adds text-to-speech for the following: