ACCESS: Add keymapper support by aunnoman1 · Pull Request #6797 · scummvm/scummvm

aunnoman1 · 2025-07-06T19:37:27Z

No description provided.

i30817 · 2025-07-07T04:11:03Z

I keep wondering if we are going to see keymapper support for individual Ags games that use custom keyboard keys to control, or worse, a combined keyboard and mouse setup.

examples are gemini rue (keyboard only shooting segments), qfg2 remake (keyboard optional combat segments, admittedly not as important) graceward and stormwater (combined keyboard for movement and mouse for aiming setup - this has no good solution in android scummvm besides using keyboard+mouse even if the right keycodes were supported because the virtual gamepad touch zones occupy all the screen so you can use both at once, and very few physical gamepads have a touch zone), all of stranga games games (only keyboard, would make sense mapping to virtual gamepad, but you can't because the keycodes on the 'right side'' are marked as generic scummvm action and don't match), probably a lot I'm forgetting.

I kind of wish for a 'advanced' escape hatch to map any keyboard keycode to any virtual controller key, that is, select both sides, not just map them to 'actions' (that are actually keycodes) that can often be wrong for engines with so many games. I shudder to think what would happen if a RPG maker engine reimplementation was added.

bluegr · 2025-07-07T05:26:08Z

I keep wondering if we are going to see keymapper support for individual Ags games that use custom keyboard keys to control, or worse, a combined keyboard and mouse setup.

examples are gemini rue (keyboard only shooting segments), qfg2 remake (keyboard optional combat segments, admittedly not as important) graceward and stormwater (combined keyboard for movement and mouse for aiming setup - this has no good solution in android scummvm besides using keyboard+mouse even if the right keycodes were supported because the virtual gamepad touch zones occupy all the screen so you can use both at once, and very few physical gamepads have a touch zone), all of stranga games games (only keyboard, would make sense mapping to virtual gamepad, but you can't because the keycodes on the 'right side'' are marked as generic scummvm action and don't match), probably a lot I'm forgetting.

I kind of wish for a 'advanced' escape hatch to map any keyboard keycode to any virtual controller key, that is, select both sides, not just map them to 'actions' (that are actually keycodes) that can often be wrong for engines with so many games. I shudder to think what would happen if a RPG maker engine reimplementation was added.

What does that AGS request have to do with this pull request on the ACCESS engine?

i30817 · 2025-07-07T06:24:01Z

Well, I've seen key remapping being done for multiple engines this last few months but I didn't see it for individual games in a engine that have different keycodes used. I was wondering if that is at all going to be a concern in this multi engine effort, because if hypothetically a Ags PR (or really, any widely used engine) is being worked on, I don't want anyone involved being unware about this issue where the games that most need usable remaps (because they're fully keyboard controlled for example)... don't get them. Or get them with names like 'skip' (for opening options, esc keycode) because well, it's skip in scumm.

I also don't think this is only a issue for AGS, it's simply the game library I know more of so I could give examples. I would expect it to happen regularly in game engines with a lot of games of PC origin. I think director probably has some, and maybe wintermute.

tag2015 · 2025-07-07T08:27:57Z

Please. don't hijack PRs for feature requests for other engines, especially considering this is a GSoC PR.
There's already a feature request for keymapper support in AGS https://bugs.scummvm.org/ticket/15356

sev-

Added couple of notes

sev- · 2025-07-07T22:08:52Z

engines/access/events.cpp

 	_keyCode = keycode;
+}
+
+void EventsManager::ActionControl(Common::CustomEventType action, bool isKeyDown) {


This must be renamed to conform to our naming conventions

sev- · 2025-07-07T22:10:20Z

engines/access/room.cpp

-			handleCommand(keyState.keycode - Common::KEYCODE_F1);
+	} else if (_vm->_events->getAction(action)) {
+		if (action >= kActionLook && action <= kActionPause)
+			handleCommand(action - kActionLook + 1);


This looks very dangerous. Why not create a mapping table or a hashmap instead?

ccawley2011 · 2025-07-09T22:16:59Z

engines/access/metaengine.cpp

+	act = new Action("PAUSE", _("General Main Menu"));
+	act->setCustomEngineActionEvent(kActionPause);
+	act->addDefaultInputMapping("F10");
+	act->addDefaultInputMapping("JOY_START");


This clashes with the Global Main Menu action.

sev-

Added my notes

sev- · 2025-07-10T12:27:46Z

engines/access/POTFILES

@@ -1 +1,2 @@
 engines/access/resources.cpp
+engines/access/metaengine.cpp


Please sort this alphabetically

sev- · 2025-07-10T12:30:43Z

engines/access/metaengine.cpp

+	act->addDefaultInputMapping("JOY_START");
+	engineKeyMap->addAction(act);
+
+	act = new Action("SKIP", _("Skip Movie"));


I had an impression that we already fixed all to the Sentence Case, no? Why are you reintroducing Title Case over all of these actions...

mgerhardy · 2025-07-11T06:21:53Z

engines/access/access.h

+
+struct AccessActionCode {
+	ACCESSActions _action;
+	int _code;


could be int8 - which would reduce the size on some systems.

mgerhardy · 2025-07-11T06:23:14Z

engines/access/events.h

 	int checkMouseBox1(Common::Array<Common::Rect> &rects);

-	bool isKeyMousePressed();
+	bool isKeyActionMousePressed();


a few of these changed methods could be const

had a look and didn't notice any which could be const. could you please specifiy which ones? Thank you

OMGPizzaGuy · 2025-07-12T19:53:45Z

This looks pretty good to me at this point.

sev- · 2025-07-21T11:00:17Z

Thank you!

sev- added the GSoC Part of a Google Summer of Code project label Jul 6, 2025

sev- requested changes Jul 7, 2025

View reviewed changes

aunnoman1 force-pushed the access-keymapper branch from 73fe36b to c8eb79b Compare July 8, 2025 21:37

aunnoman1 requested a review from sev- July 8, 2025 22:18

ccawley2011 reviewed Jul 9, 2025

View reviewed changes

sev- requested changes Jul 10, 2025

View reviewed changes

aunnoman1 force-pushed the access-keymapper branch from c8eb79b to ee0484a Compare July 10, 2025 23:30

mgerhardy reviewed Jul 11, 2025

View reviewed changes

OMGPizzaGuy approved these changes Jul 12, 2025

View reviewed changes

ACCESS: Add keymapper support

f1c233b

aunnoman1 force-pushed the access-keymapper branch from ee0484a to f1c233b Compare July 13, 2025 23:23

aunnoman1 requested review from mgerhardy and sev- July 14, 2025 14:26

sev- merged commit 436d947 into scummvm:master Jul 21, 2025
8 checks passed

		@@ -1 +1,2 @@
		engines/access/resources.cpp
		engines/access/metaengine.cpp

Uh oh!

Conversation

aunnoman1 commented Jul 6, 2025

Uh oh!

i30817 commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bluegr commented Jul 7, 2025

Uh oh!

i30817 commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tag2015 commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sev- left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sev- left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OMGPizzaGuy commented Jul 12, 2025

Uh oh!

sev- commented Jul 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

i30817 commented Jul 7, 2025 •

edited

Loading

i30817 commented Jul 7, 2025 •

edited

Loading

tag2015 commented Jul 7, 2025 •

edited

Loading