PARALLACTION: Add text-to-speech (TTS)#6795
Merged
sev- merged 1 commit intoscummvm:masterfrom Jul 21, 2025
Merged
Conversation
sev-
requested changes
Jul 10, 2025
engines/parallaction/exec_ns.cpp
Outdated
| "Der Pachinko-Spieler" | ||
| }; | ||
|
|
||
| static const int kNumberOfCredits = 39; |
Member
There was a problem hiding this comment.
Suggested change
| static const int kNumberOfCredits = 39; | |
| static const int kNumberOfCredits = ARRAYSIZE(endCreditsItalian); |
| bool male; | ||
| }; | ||
|
|
||
| static const CharacterVoiceData characterVoiceDatas[] = { |
|
|
||
| namespace Parallaction { | ||
|
|
||
| static const char *openingCreditsFirstLine[] = { |
Member
There was a problem hiding this comment.
also, wrap it into #ifdef USE_TTS please
mgerhardy
reviewed
Jul 11, 2025
| charName = "Donna Fatale"; | ||
| break; | ||
| case kDino: | ||
| charName = "Dino Fagioli"; |
Contributor
There was a problem hiding this comment.
maybe add the missing break here - just in case anyone is adding a new case
| creditsTexts = germanCredits; | ||
| break; | ||
| default: | ||
| creditsTexts = englishCredits; |
Contributor
There was a problem hiding this comment.
maybe add the missing break here, too - just in case
engines/parallaction/parallaction.h
Outdated
| }; | ||
|
|
||
| struct CharacterVoiceData { | ||
| Common::String characterName; |
Contributor
There was a problem hiding this comment.
maybe use a const char * here to reduce the size of the struct as the Common::String has some internal storage that might add empty bytes and wastes memory.
also the voiceID could be uint8
f3ae275 to
d8936ba
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a toggle for text-to-speech to the game options.
Adds text-to-speech for the following:
Currently only tested with Nippon Safes, Inc.
The following hardcoded translations need verification: