Merged
Conversation
ccawley2011
reviewed
Jul 9, 2025
engines/buried/biochip_right.cpp
Outdated
| _vm->_sound->timerCallback(); | ||
| delete video; | ||
|
|
||
| keymapper->getKeymap("cutscene")->setEnabled(false); |
Member
There was a problem hiding this comment.
Would it make sense to create a helper function that enables and disables keymaps using an enum?
Member
There was a problem hiding this comment.
Indeed, something like
void enableCutSceneKeymap(bool enable) {
keymapper->getKeymap("cutscene")->setEnabled(enable);
keymapper->getKeymap("buried-default")->setEnabled(!enable);
...And then you call here enableCutSceneKeymap(false)
engines/buried/metaengine.cpp
Outdated
| act->addDefaultInputMapping("JOY_A"); | ||
| engineKeyMap->addAction(act); | ||
|
|
||
| // I18N: This action refers to the control key. |
Member
There was a problem hiding this comment.
Suggested change
| // I18N: This action refers to the control key. | |
| // I18N: This action refers to the control key on the keyboard. |
engines/buried/metaengine.cpp
Outdated
| act->addDefaultInputMapping("JOY_A"); | ||
| inventoryKeyMap->addAction(act); | ||
|
|
||
| // I18N: The game has an inventory with a list of biochips. This action is used to switch the equiped biochip to AI biochip. |
Member
There was a problem hiding this comment.
Suggested change
| // I18N: The game has an inventory with a list of biochips. This action is used to switch the equiped biochip to AI biochip. | |
| // I18N: The game has an inventory with a list of biochips. This action is used to switch the equipped biochip to the AI biochip. |
Ditto for the other biochip actions.
Member
There was a problem hiding this comment.
Suggested change
| // I18N: The game has an inventory with a list of biochips. This action is used to switch the equiped biochip to AI biochip. | |
| // I18N: The game has an inventory with a list of biochips. This action is used to switch the equipped biochip to the Artificial Intelligence biochip. |
engines/buried/metaengine.cpp
Outdated
| act = new Action("SAVE", _("Save game")); | ||
| act->setCustomEngineActionEvent(kActionSave); | ||
| act->addDefaultInputMapping("C+s"); | ||
| act->addDefaultInputMapping("JOY_LEFT"); |
Member
There was a problem hiding this comment.
This clashes with the movement actions.
engines/buried/metaengine.cpp
Outdated
| act->setCustomEngineActionEvent(kActionLoad); | ||
| act->addDefaultInputMapping("C+l"); | ||
| act->addDefaultInputMapping("C+o"); | ||
| act->addDefaultInputMapping("JOY_RIGHT"); |
Member
There was a problem hiding this comment.
This clashes with the movement actions.
engines/buried/metaengine.cpp
Outdated
| act = new Action("AICOMMENTS", _("Replay last AI comment")); | ||
| act->setCustomEngineActionEvent(kActionAIComment); | ||
| act->addDefaultInputMapping("SPACE"); | ||
| act->addDefaultInputMapping("JOY_A"); |
Member
There was a problem hiding this comment.
This clashes with the left click action.
sev-
requested changes
Jul 10, 2025
engines/buried/biochip_right.cpp
Outdated
| _vm->_sound->timerCallback(); | ||
| delete video; | ||
|
|
||
| keymapper->getKeymap("cutscene")->setEnabled(false); |
Member
There was a problem hiding this comment.
Indeed, something like
void enableCutSceneKeymap(bool enable) {
keymapper->getKeymap("cutscene")->setEnabled(enable);
keymapper->getKeymap("buried-default")->setEnabled(!enable);
...And then you call here enableCutSceneKeymap(false)
| act->addDefaultInputMapping("C+q"); | ||
| gameKeyMap->addAction(act); | ||
|
|
||
| act = new Action("AICOMMENTS", _("Replay last AI comment")); |
Member
There was a problem hiding this comment.
Suggested change
| act = new Action("AICOMMENTS", _("Replay last AI comment")); | |
| // AI is Artificial Intelligence | |
| act = new Action("AICOMMENTS", _("Replay last AI comment")); |
engines/buried/metaengine.cpp
Outdated
| act->addDefaultInputMapping("JOY_A"); | ||
| inventoryKeyMap->addAction(act); | ||
|
|
||
| // I18N: The game has an inventory with a list of biochips. This action is used to switch the equiped biochip to AI biochip. |
Member
There was a problem hiding this comment.
Suggested change
| // I18N: The game has an inventory with a list of biochips. This action is used to switch the equiped biochip to AI biochip. | |
| // I18N: The game has an inventory with a list of biochips. This action is used to switch the equipped biochip to the Artificial Intelligence biochip. |
07970ed to
b9960d4
Compare
OMGPizzaGuy
reviewed
Jul 12, 2025
b9960d4 to
91530d7
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.