Conversation
|
With Return to Zork everything seems to work well, except for the crash I indicated. In that game dialogs are voiced and I am getting both TTS and the original voice, which is not great. Also in the Play'O'Matic screen when I click on the different slots it always speak the text from the last one. |
4722a4a to
e6031a6
Compare
engines/made/made.cpp
Outdated
| return true; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This function does not work for me because the text indices in my version are different from the one in lgop2PlayOMaticTextIndices
I have (French version) 14851, 15596, 15599, 15605, 15611, 15617, 15624, 15631, 15635, 15641, 15646, 15652, 15656, 15660, 15667, 15673, 15681, 15687, 15690, 15695, 15701.
I suspect these are not the only text indices that differ. Using those to identify the text in various places seems a bit fragile. But I don't really have a better idea. Maybe it would be better to check we are on the PlayOMatic screen and what the _textX and _textY values are instead of relying on the text indices?
There was a problem hiding this comment.
The other solution that I could think of that doesn't involve using text indices is using sprite indices. I think that this would probably work better across versions, but there are risks, like a sprite being used more than once in the game (which would make it a poor indicator for a unique piece of text) or the chance that there isn't a sprite drawn before a specific piece of text is printed. Because of this, while I did switch over the Play'O'Matic text to rely more on the sprite index, which should fix the crash, I left the others unchanged for now. Would it be preferred to switch to using sprite indices?
There was a problem hiding this comment.
It might be better. Currently none of the code that relies on the text indices is working for me in LGOP.
For example:
// 13484 is the "over a decade of the best interactive fiction" line in the beginning, which has no voiceover
// 14185 is the "choose your character" message, and 13876 is the copyright message in the intro
Those are 14851 and 15589 respectively for me. So that don't get voiced currently.
|
Thanks! |
Adds a toggle for text-to-speech to the game options.
Adds text-to-speech for the following:
Currently only tested with the Return to Zork DOS demos.
Translations for the opening credits (in
pmvplayer.cpp) need verification.