Merged
Conversation
ccawley2011
reviewed
Jul 9, 2025
engines/sword25/metaengine.cpp
Outdated
| act->addDefaultInputMapping("JOY_RIGHT_SHOULDER"); | ||
| engineKeyMap->addAction(act); | ||
|
|
||
| act = new Action("REVEALHOTSPOTS", _("Reveal all interactive hotspots (hold)")); |
Member
There was a problem hiding this comment.
Would it be possible to expand on "hold" for clarity? Presumably it means that the key/button needs to be held down in order to take effect?
Member
There was a problem hiding this comment.
Suggested change
| act = new Action("REVEALHOTSPOTS", _("Reveal all interactive hotspots (hold)")); | |
| act = new Action("REVEALHOTSPOTS", _("Reveal all interactive hotspots (hold the key)")); |
sev-
requested changes
Jul 10, 2025
Member
sev-
left a comment
There was a problem hiding this comment.
Only two small notes and it is good to go
engines/sword25/metaengine.cpp
Outdated
| using namespace Sword25; | ||
|
|
||
| Keymap *engineKeyMap = new Keymap(Keymap::kKeymapTypeGame, "sword25-default", _("Default keymappings")); | ||
| Keymap *debugKeyMap = new Keymap(Keymap::kKeymapTypeGame, "debug", _("Debug keymappings")); |
Member
There was a problem hiding this comment.
Shouldn't this also be checked against the debug flag?
engines/sword25/metaengine.cpp
Outdated
|
|
||
| KeymapArray keymaps(2); | ||
| keymaps[0] = engineKeyMap; | ||
| keymaps[1] = debugKeyMap; |
Member
There was a problem hiding this comment.
Shouldn't this also be checked against the debug flag?
ce71b06 to
6e4845f
Compare
6e4845f to
1b9704d
Compare
Member
|
Thanks for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.