I18N: Normalize keymapper action descriptions#6759
Merged
sev- merged 92 commits intoscummvm:masterfrom Jun 24, 2025
Merged
Conversation
OMGPizzaGuy
reviewed
Jun 21, 2025
OMGPizzaGuy
reviewed
Jun 21, 2025
OMGPizzaGuy
reviewed
Jun 21, 2025
OMGPizzaGuy
reviewed
Jun 21, 2025
sev-
reviewed
Jun 21, 2025
engines/pegasus/pegasus.cpp
Outdated
| engineKeyMap->addAction(act); | ||
|
|
||
| act = new Action("TBI", _("Display/Hide Biochip Tray")); | ||
| act = new Action("TBI", _("Display / Hide biochip tray")); |
Member
There was a problem hiding this comment.
Why not use Toggle for consistency?
sev-
reviewed
Jun 21, 2025
engines/touche/metaengine.cpp
Outdated
|
|
||
| { | ||
| act = new Action("SKIPORQUIT", _("Skip sequence/open quit dialogue")); | ||
| act = new Action("SKIPORQUIT", _("Skip sequence / open quit dialogue")); |
Member
There was a problem hiding this comment.
Please switch to American English, e.g., dialog instead of dialogue. Same thing below.
sev-
reviewed
Jun 21, 2025
engines/tsage/metaengine.cpp
Outdated
| gameKeyMap->addAction(act); | ||
|
|
||
| act = new Common::Action("RIGHT", _("Turn Right/Crawl East")); | ||
| act = new Common::Action("RIGHT", _("Turn right/Crawl East")); |
Member
There was a problem hiding this comment.
Suggested change
| act = new Common::Action("RIGHT", _("Turn right/Crawl East")); | |
| act = new Common::Action("RIGHT", _("Turn right / Crawl east")); |
sev-
reviewed
Jun 21, 2025
engines/tsage/metaengine.cpp
Outdated
| gameKeyMap->addAction(act); | ||
|
|
||
| act = new Common::Action("LEFT", _("Turn Left/Crawl West")); | ||
| act = new Common::Action("LEFT", _("Turn left/Crawl West")); |
Member
There was a problem hiding this comment.
Suggested change
| act = new Common::Action("LEFT", _("Turn left/Crawl West")); | |
| act = new Common::Action("LEFT", _("Turn left / Crawl west")); |
sev-
reviewed
Jun 21, 2025
engines/twine/metaengine.cpp
Outdated
| gameKeyMap->addAction(act); | ||
|
|
||
| act = new Action("CHANGETONORMALBEHAVIOUR", _("Normal Behaviour")); | ||
| act = new Action("CHANGETONORMALBEHAVIOUR", _("Normal behaviour")); |
Member
There was a problem hiding this comment.
US English here too, please. behavior, and below.
sev-
reviewed
Jun 21, 2025
| { KEYBIND_DOWN, "DOWN", "Down", nullptr, "DOWN", nullptr }, | ||
| { KEYBIND_LEFT, "LEFT", "Left", nullptr, "LEFT", nullptr }, | ||
| { KEYBIND_RIGHT, "RIGHT", "Right", nullptr, "RIGHT", nullptr }, | ||
| { KEYBIND_ESCAPE, "ESCAPE", _s("Escape"), nullptr, "ESCAPE", nullptr }, |
Member
There was a problem hiding this comment.
This sounds more like 'abort' ot 'stop', not "escape" in the meaning of "run away from the room"
sev-
requested changes
Jun 21, 2025
Member
sev-
left a comment
There was a problem hiding this comment.
Reviewed and added some notes.
In general, pretty good work.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.