CRUISE: Fix TTS encoding, empty text queuing, and logo speech#6752
Merged
criezy merged 1 commit intoscummvm:masterfrom Jun 21, 2025
Merged
CRUISE: Fix TTS encoding, empty text queuing, and logo speech#6752criezy merged 1 commit intoscummvm:masterfrom
criezy merged 1 commit intoscummvm:masterfrom
Conversation
criezy
reviewed
Jun 20, 2025
engines/cruise/cruise.cpp
Outdated
|
|
||
| if (getLanguage() == Common::RU_RUS) { | ||
| if (getLanguage() == Common::FR_FRA || getLanguage() == Common::IT_ITA) { | ||
| _ttsTextEncoding = Common::CodePage::kISO8859_1; |
Member
There was a problem hiding this comment.
Suggested change
| _ttsTextEncoding = Common::CodePage::kISO8859_1; | |
| _ttsTextEncoding = Common::CodePage::kWindows1252; |
I don't know if this is actually needed, but that should do no harm. Windows-1252 is an extension of Latin1, adding a few printable characters in places where Latin1 has non-printable characters. For French that would notably be the œ missing in Latin1, but used for example in cœur (heart or core), sœur (sister), or œuf (egg), all quite common words that could be used in the game and may use that character (although they may also be spell with oe in which case both Latin1 and Windows-1252 would work).
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few issues with TTS.