TEENAGENT: Fix Russian TTS encoding#6722
Merged
criezy merged 1 commit intoscummvm:masterfrom Jun 19, 2025
Merged
Conversation
criezy
reviewed
Jun 15, 2025
bluegr
reviewed
Jun 16, 2025
engines/teenagent/teenagent.cpp
Outdated
|
|
||
| Common::U32String TeenAgentEngine::convertCyrillic(const Common::String &text) const { | ||
| const byte *bytes = (const byte *)text.c_str(); | ||
| byte result[10240]; |
Member
There was a problem hiding this comment.
Why do you need a fixed size in this buffer? You already know the length of the original text, can't you deduce the buffer length from that?
i.e:
Suggested change
| byte result[10240]; | |
| char *result = new char[bytes.size() * 2 + 1]; | |
| (...) | |
| result[i] = 0; | |
| (...) | |
| Common::U32String res(result); | |
| delete[] result; | |
| return res; |
Member
|
This seems fine. The one check that failed in a compilation error in the lastexpress engine, so not relevant. |
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes text-to-speech for the Russian translation, which uses a custom encoding.