CINE: Add text-to-speech (TTS) by ellm135 · Pull Request #6700 · scummvm/scummvm

ellm135 · 2025-06-08T23:01:08Z

Adds a toggle for text-to-speech to the game options.
Adds text-to-speech for the following:

Copy protection screen
Credits
Inventory items
System and action menus
Command line
Cutscene text
Dialog and popup information

criezy · 2025-06-15T23:47:30Z

For the hardcoded text that corresponds to images (e.g. copy protection and credits), do some of the translations need to be checked by native speakers, and if so which ones?

ellm135 · 2025-06-16T20:48:05Z

For the hardcoded text that corresponds to images (e.g. copy protection and credits), do some of the translations need to be checked by native speakers, and if so which ones?

This hardcoded text needs to be checked:

"The End" texts in Spanish ~~all languages but English~~
All opening and end credits in Spanish ~~all languages but English and French (except for the Operation Stealth final end credits screen: only the German translation for this needs verification)~~

criezy · 2025-06-30T14:31:01Z

engines/cine/gfx.cpp

+	"Tutto il gruppo della Delphine spera che John Glames vi abbia fatto trascorrere dei momenti piacevoli "
+	"e vi ringrazia della fiducia accordata.\n"
+	"Appuntamento a presto per una nuova aventura."
+};


I am thinking those arrays could be in a #ifdef USE_TTS block so that they are not included when compiling without TTS support (which may include platforms with restricted amount of memory. That would also mean adding the #ifdef USE_TTS around the blocks of code below in the same file that handles TTS.

Yes, good idea

tag2015 · 2025-06-30T17:49:58Z

engines/cine/gfx.cpp

+	"Musica Jean Baudlot",
+	"",									// DOS only (no DOS version exists)
+	"Future Wars: Time Travellers",		// Amiga/Atari only
+	""									// DOS only (no DOS version exists)


Using the english strings as reference, I'd propose:
"Idea e programmazione di Paul Cuisset"
"Direzione grafica di Eric Chahi"
"Musica composta da Jean Baudlot"
For the first string you can also use "Progettazione" or "Ideazione" instead of "Idea". Or, you can also keep "Design" which is used also in Italian, and it sounds better IMHO

This is the text as it is presented in-game.

I haven't checked with the game but isn't there a comment "German, Spanish, and Italian credits are in English in-game, but are translated here for TTS" ?

The Italian translation of Future Wars does have its opening credits in English in-game.

tag2015 · 2025-06-30T17:53:44Z

engines/cine/gfx.cpp

+	"Patricia Vermander",
+
+	// Italian, first line
+	"Disegno: Paul Cuisset",


"Disegno" is wrong. As in the opening credits you can choose between Idea/Ideazione/Progettazione/Design

tag2015 · 2025-06-30T17:54:24Z

engines/cine/gfx.cpp

+	// Italian, second line Amiga/Atari
+	"Programmazione: Paul Cuisset",
+	// Italian, remainder of credits
+	"Grafiche: Eric Chahi\n"


tag2015 · 2025-06-30T17:56:41Z

engines/cine/gfx.cpp

+	"Aiuto tecnico: Philippe Chastel, Jesus Martinez\n"
+	"Campionamento di suoni digitalizzati: Philippe Chastel, Paul Cuisset, Antoine O'Heix, Jesus Martinez\n"
+	"Sistema Cinematique: Paul Cuisset\n"
+	"Molte grazie a: Philippe Delamarre, Emmanuel Lecoz, Michael Sportouch, Peter Stone, Matthew Tims, "


"Ringraziamenti a:" or "Sentiti ringraziamenti a"

tag2015 · 2025-06-30T17:57:47Z

engines/cine/gfx.cpp

+static const char *openingCreditsOSItalian[] = {
+	"Copione\nP. Cuisset\nP. Chastel",
+	"Illustrazioni\nImagex\nM. Bacque\nE. Lecoz",
+	"Programma\nP. Cuisset\nP. Chastel\nJ. Martinez",


Programmazione

tag2015 · 2025-06-30T18:06:47Z

engines/cine/gfx.cpp

+	// Italian
+	"Copione\n Paul Cuisset, Philippe Chastel\n"
+	"Programmazione\n Paul Cuisset, Philippe Chastel, J\202sus Martinez, Daniel Morais IBM PC\n"
+	"Illustrazioni\n Mich\212le Bacqu\202, Imagex, Emmanuel Lecoz\n"


The english string is "Illustrations", but I think this one should be "Grafica"

tag2015 · 2025-06-30T18:07:09Z

engines/cine/gfx.cpp

+	"Musica\n Jean Baudlot\n"
+	"Effetti sonori\n Marc Minier\n"
+	"Manuale dell'utente\n Michael Sportouch\n"
+	"Manuale di illustrazione\n Jean-Pierre Fert\202\n"


Illustrazioni del manuale

tag2015 · 2025-06-30T18:10:25Z

engines/cine/gfx.cpp

+	// Italian, final credits screen
+	"Tutto il gruppo della Delphine spera che John Glames vi abbia fatto trascorrere dei momenti piacevoli "
+	"e vi ringrazia della fiducia accordata.\n"
+	"Appuntamento a presto per una nuova aventura."


Typo, should be "avventura"

athrxx · 2025-06-30T18:37:04Z

engines/cine/gfx.cpp

+	"Kopierschutz\n"
+	"Auf der R\201ckseite des Einbandes der \"Future Wars\" Anleitung findest Du einen farbigen "
+	"Abdruck der Kopierschutzabfrage des Programmes.\n"
+	"Du mu\236t nur die richtige Farbe des blinkenden Ausscnitts auf dem Bildschirm gem\204\236 der "


Ausschnitts

athrxx · 2025-06-30T18:38:05Z

engines/cine/gfx.cpp

+	"la ligne demand\202e.",
+	// German
+	"Sicherheitsabfrage\n"
+	"Bitte die gitterfolie auf die seite legen, die angezeigt wird!\n"


Gitterfolie
Seite

athrxx · 2025-06-30T18:43:35Z

engines/cine/gfx.cpp

+	// German
+	"Sicherheitsabfrage\n"
+	"Bitte die gitterfolie auf die seite legen, die angezeigt wird!\n"
+	"Dann bestimmen sie mit cursorpfeil und click das entsprechende feld.",


Dann klicken Sie auf das entsprechende Feld.

This text was taken from the game, so I've left it mostly unchanged for now (though I did fix the capitalization as suggested).

Okay, I see. This isn't real German. More like something that they might have forgotten to give to the translator and then had to make up something themselves :-). But it is understandable at least...
If you just want to have the capitalization correct, it is
"Dann bestimmen Sie mit Cursorpfeil und Click das entsprechende Feld."

Then since the original translation is too incorrect, I've replaced it with the initial suggestion. Thank you!

athrxx · 2025-06-30T18:44:25Z

engines/cine/gfx.cpp

+
+static const char *copyProtectionTextsOSGerman[] = {
+	"Operation Stealth",
+	"Die informationen dieses dossiers sind: "


Die Informationen dieses Dossiers sind:

athrxx · 2025-06-30T18:45:32Z

engines/cine/gfx.cpp

+	"Operation Stealth",
+	"Die informationen dieses dossiers sind: "
+	"Streng Geheim",
+	"Bitte entnehmen sie der code-karte die zugeh\224rige farbe, um ihre zugriffsberechtigung zu best\204tigen."


Bitte entnehmen Sie der Codekarte die zugeh\224rige Farbe, um Ihre Zugriffsberechtigung zu best\204tigen.

athrxx · 2025-06-30T18:46:02Z

engines/cine/gfx.cpp

+static const char *copyProtectionFailTextsOS[] = {
+	"Sorry, the colors you just chose don't match.",                // English
+	"Les couleurs que vous avez choisies ne correspondent pas.",    // French
+	"Die Farben, die Sie gew\204hlt haben sind falsch.",            // German


Die Farben, die Sie gew\204hlt haben, sind falsch.

AndywinXp · 2025-06-30T20:07:26Z

engines/cine/gfx.cpp

+	"(columna y fila) ya pincha sobre ella.",
+	// Italian
+	"Protezione da copie illegali\n"
+	"Metti la griglia che hai trovato nella confezione sulla pagina del manuale il cui numero e' indicato.\n"


e' should be è, but check if there's an escape code for that character.

Maybe the escape code is \350, please check if it's true.

It was \212 in this case. Thank you!

engines/cine/gfx.cpp

mgerhardy · 2025-07-11T06:26:36Z

engines/cine/cine.cpp

+		_ttsLanguage = kItalian;
+		break;
+	default:
+		_ttsLanguage = kEnglish;


just for completeness - maybe add a break to the default case, too - even though it should be last, one could still add another case at the end and then forgets to add the break.

mgerhardy · 2025-07-11T06:32:45Z

engines/cine/cine.cpp

 }

+void CineEngine::sayText(const Common::String &text, Common::TextToSpeechManager::Action action) {
+	Common::TextToSpeechManager *ttsMan = g_system->getTextToSpeechManager();


isnt't here the #ifdef USE_TTS missing?

I think that, for functions like sayText, the #ifdef USE_TTS shouldn't be necessary.

sev- · 2025-07-21T10:34:30Z

Thank you! Merging

OMGPizzaGuy added the GSoC Part of a Google Summer of Code project label Jun 8, 2025

ellm135 force-pushed the cine-tts branch 2 times, most recently from 7364007 to 3311d10 Compare June 28, 2025 02:39

ellm135 marked this pull request as ready for review June 28, 2025 02:41

criezy reviewed Jun 30, 2025

View reviewed changes

tag2015 reviewed Jun 30, 2025

View reviewed changes

athrxx reviewed Jun 30, 2025

View reviewed changes

AndywinXp reviewed Jun 30, 2025

View reviewed changes

engines/cine/gfx.cpp Show resolved Hide resolved

ellm135 force-pushed the cine-tts branch 2 times, most recently from a0eeebe to 2c2db63 Compare July 2, 2025 20:30

ellm135 force-pushed the cine-tts branch from 2c2db63 to eb4e012 Compare July 10, 2025 17:43

mgerhardy reviewed Jul 11, 2025

View reviewed changes

CINE: Add text-to-speech (TTS)

21e3d1b

ellm135 force-pushed the cine-tts branch from eb4e012 to 21e3d1b Compare July 11, 2025 19:28

sev- merged commit d8f456b into scummvm:master Jul 21, 2025
8 checks passed

Uh oh!

Conversation

ellm135 commented Jun 8, 2025

Uh oh!

criezy commented Jun 15, 2025

Uh oh!

ellm135 commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sev- commented Jul 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

ellm135 commented Jun 16, 2025 •

edited

Loading