Conversation
0ae99d2 to
7f46f0e
Compare
criezy
left a comment
There was a problem hiding this comment.
I only looked at the MACGUI part of the PR, but I think it needs some changes.
graphics/macgui/macmenu.cpp
Outdated
|
|
||
| _screen.fillRect(trect, _wm->_colorBlack); | ||
|
|
||
| _wm->sayText(menu->items[i]->text); |
There was a problem hiding this comment.
I think here you need to check menu->items[i]->unicode and either speak test or unicodeText?
criezy
left a comment
There was a problem hiding this comment.
I only have one issue left, related to the encoding when converting from String to U32String in the macgui.
In general you will need to be careful about such conversion in all the engines in which you are adding TTS.
graphics/macgui/macmenu.cpp
Outdated
| if (menu->items[i]->unicode) { | ||
| _wm->sayText(menu->items[i]->unicodeText); | ||
| } else { | ||
| _wm->sayText(menu->items[i]->text); |
There was a problem hiding this comment.
In this case where you are not using a unicode text, it needs to be converted to unicode using the correct encoding, which I suspect is not the default kUtf8.
See MacFontRun::getEncoding() and MacMenu::getMenuFont() which should give you the information you need.
|
Thank you! |
Adds a toggle for text-to-speech to the game options.
Adds text-to-speech for the following: