TEENAGENT: Add text-to-speech (TTS)#6566
Merged
criezy merged 3 commits intoscummvm:masterfrom Jun 4, 2025
Merged
Conversation
sev-
requested changes
Apr 25, 2025
engines/teenagent/detection.h
Outdated
|
|
||
| #define GAMEOPTION_TTS GUIO_GAMEOPTIONS1 | ||
|
|
||
| #endif // TEENAGENT_DETECTION_H No newline at end of file |
criezy
requested changes
May 26, 2025
Member
criezy
left a comment
There was a problem hiding this comment.
I have added two comments:
- possible missing sanity check
- check if it would be useful to add TTS in the versions that have speech for the non-voiced text (e.g.inventory items).
In addition to those, did you check if there is a way to know which character is speaking? That would allow to use a difference voice for each character. But this may not be possible.
c884eae to
d96bb65
Compare
criezy
reviewed
Jun 3, 2025
engines/teenagent/dialog.h
Outdated
| kEskimo = 18, | ||
| kMike = 19, | ||
| kMarkEnd = 20, | ||
| kCredits = 21 |
Member
There was a problem hiding this comment.
Please rename this kCredits to something else (for example kCreditsText) and update all the places where it is used. There is already a kCredits defined in scene.h and while it is restricted to the SceneEvent struct scope it still generates a warning currently in all the files that include both dialog.h and scene.h:
./engines/teenagent/scene.h:62:6: warning: declaration shadows a variable in namespace 'TeenAgent' [-Wshadow]
62 | kCredits,
| ^
./engines/teenagent/dialog.h:78:2: note: previous declaration is here
78 | kCredits = 21
| ^
Currently, the Polish and Czech versions have all text in English. Therefore, the TTS language for these versions should be English to match the text. The Polish CD/Floppy versions also have no working voiceover, so they need full TTS.
criezy
approved these changes
Jun 4, 2025
Member
criezy
left a comment
There was a problem hiding this comment.
Thank you. It looks all good now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a toggle for text-to-speech in the game options.
Adds text-to-speech for the following: