Merged
Conversation
sev-
requested changes
Mar 30, 2025
Member
sev-
left a comment
There was a problem hiding this comment.
Good shape, I have only couple of minor notes
engines/toltecs/menu.cpp
Outdated
| _returnToGame = true; | ||
|
|
||
| Common::Keymapper *keymapper = _vm->getEventManager()->getKeymapper(); | ||
| keymapper->getKeymap("toltecs-default")->setEnabled(false); |
Member
There was a problem hiding this comment.
Suggested change
| keymapper->getKeymap("toltecs-default")->setEnabled(false); | |
| // Now we turn off the keymapper so it does not interfere with full text input | |
| keymapper->getKeymap("toltecs-default")->setEnabled(false); |
engines/toltecs/movie.cpp
Outdated
| if (event.kbd.keycode == Common::KEYCODE_ESCAPE) | ||
| case Common::EVENT_CUSTOM_ENGINE_ACTION_START: | ||
| switch (event.customType) { | ||
| case (kActionSkipMovie): |
Member
There was a problem hiding this comment.
why?
Suggested change
| case (kActionSkipMovie): | |
| case kActionSkipMovie: |
and it other places
engines/toltecs/toltecs.h
Outdated
|
|
||
| #include "toltecs/console.h" | ||
|
|
||
| #include "backends/keymapper/action.h" |
Member
There was a problem hiding this comment.
Are these needed here? We try to minimize include dependencies.
9eb0e5d to
ddedd7f
Compare
ddedd7f to
c1a5226
Compare
OMGPizzaGuy
reviewed
Mar 30, 2025
OMGPizzaGuy
reviewed
Mar 30, 2025
c1a5226 to
e3c6bfe
Compare
Contributor
Author
|
Thank you for the suggestions @OMGPizzaGuy . I've implemented them. ALso fixed an issue which made joystick binds not work in game menu by readjusting where the keymaps are enabled and disabled |
Member
|
OK, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.