Skip to content

Conversation

@haerdib
Copy link
Contributor

@haerdib haerdib commented Feb 19, 2024

closes #720

@haerdib haerdib self-assigned this Feb 19, 2024
@haerdib haerdib added F3-test fix tests or CI E0-silent Will not be mentioned in the release labels Feb 19, 2024
@haerdib haerdib marked this pull request as ready for review February 19, 2024 08:39
@haerdib haerdib requested a review from masapr February 19, 2024 08:40
Copy link
Collaborator

@masapr masapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.
Unfortunately we still get the original warning
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: styfle/cancel-workflow-action@0.11.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
So let's remove the "closes #720". Nevertheless, I think this change makes sense, so let's merge it.

@haerdib
Copy link
Contributor Author

haerdib commented Feb 19, 2024

I have created a separate issue instead, as this warning is likely generated by a different part of our CI: #723

@haerdib haerdib merged commit 89c5e1a into master Feb 19, 2024
@haerdib haerdib deleted the bh/720-use-new-paritpr-node branch February 19, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

E0-silent Will not be mentioned in the release F3-test fix tests or CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use new docker image of substrate in CI

3 participants