Add submit_and_watch_extrinsic_until_success method
#398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d3b5b3 to
45e43b6
Compare
extract separate functions move trait to top fix ci fix no-std build serde_full fix clippy remove no good test remove comment
45e43b6 to
5cf49eb
Compare
clangenb
approved these changes
Jan 2, 2023
Collaborator
clangenb
left a comment
There was a problem hiding this comment.
Nice, looks good to me!
clangenb
reviewed
Jan 2, 2023
Comment on lines
+161
to
+165
| Runtime::Hashing: HashTrait<Output = Runtime::Hash>, | ||
| Runtime: FrameSystemConfig + GetRuntimeBlockType, | ||
| Runtime::RuntimeBlock: BlockTrait + DeserializeOwned, | ||
| Runtime::Hashing: HashTrait<Output = Runtime::Hash>, | ||
| Runtime::Hash: FromHexString, |
Collaborator
There was a problem hiding this comment.
I see us repeatedly having these excessive trait bounds. I would vote for adding them to the respective pallet's config, so we don't need to repeat them here every time.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to watch an extrinsic and automatically checks if the extrinsic was successful or not (by retrieving and checking the associated events).
closes #288