SubmitAndWatch: Return ExtrinsicReport instead of block hash
#386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
report instead of block hashExtrinsicReport instead of block hash
haerdib
commented
Dec 20, 2022
…s/substrate-api-client into bh/return-report-instead-hash
clangenb
reviewed
Dec 22, 2022
Collaborator
clangenb
left a comment
There was a problem hiding this comment.
Looks very nice and clean, I like it. I have just some questions. :)
clangenb
reviewed
Dec 22, 2022
Collaborator
clangenb
left a comment
There was a problem hiding this comment.
Very nice, I only have a comment left.
src/api/rpc_api/subscribe_events.rs
Outdated
| DispatchError::decode_from(event_details.field_bytes(), self.metadata()); | ||
| return Err(Error::Dispatch(dispatch_error)) | ||
| } | ||
| event_details.check_failed()?; |
Collaborator
There was a problem hiding this comment.
I am uncertain if I agree with the naming. I propose a few here:
- check_if_failed
- xt_successful
- xt_failed
What do you think?
Contributor
Author
There was a problem hiding this comment.
I was thinking about the first one as well. Let me adapt.
…s/substrate-api-client into bh/return-report-instead-hash
clangenb
approved these changes
Dec 22, 2022
Collaborator
clangenb
left a comment
There was a problem hiding this comment.
Thanks, looks good to me now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Breaks
submit_and_watch_extrinsicandsubmit_extrinsicinterfaces:submit_and_watch_extrinsichas been updated toExtrinsicReportwhich includes the extrinsic hash, the (maybe) block hash, the transaction status and, possibly, the associated events. This has the following advantages:submit_extrinsic) and the block hash previously returned.Preparatory step for #288.