Php8.1 v9#94
Merged
Merged
Conversation
Contributor
Author
|
Where are we at with this? I just noticed I had targeted the wrong branch, but just fixed it. This is a no brainer merger and publish a new version. Then you are PHP 8.1 compatible! |
allejo
approved these changes
Dec 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the V9 compatible version.
PHP 8.1 needs #[\ReturnTypeWillChange] on classes that implement \ArrayAccess, \Countable, or \IteratorAggregate
As this is a comment in pre 8.1 versions, it is completely backward compatible. In PHP 8.1, it prevents a depreciation notice.
It would be nice to merge quickly and create a new version that is 8.1 compatible.
Thanks!