Fix the atrocious performance of matching regexes after 9.16.0#84
Merged
Conversation
Collaborator
|
Glad you figured it out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 9.16, I introduced the
RegExclass in order to keep the PHP code aesthetically close to what the JS equivalent would be. However, the performance forRegExwas atrocious because instead of stopping after the first match, it continued moving on to find all of the matches (preg_matchvspreg_match_all).This PR fixes the atrocious performance but doesn't quite match the performance seen in 9.15 and below. I'm currently seeing 0.15 seconds with this PR where 9.15 had 0.09 seconds. The difference is... fairly negligible compared to the 40 second time currently in 9.18.
Fixes #78