Fix splitCodeIntoArray when it has nested spans + newlines#79
Merged
Conversation
Collaborator
Author
|
Ran some benchmarks on calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
splitCodeIntoArrayfunction was generating broken HTML when there were deeply nested\ncharacters because it wasn't closing the correct number of<span>tags.Marking this as a draft to see what the performance impact is by using XPath.Originally,
splitCodeIntoArraywas working off the assumption that<span>s would only nest one level deep when splitting on new lines. Notice thespan.hljs-paramselement is a child tospan.hljs-function. Because of this assumption, we were closing thehljs-paramsspan but not thehljs-functionspan.Output from
highlightCurrent
splitCodeIntoArrayoutput:What it should look like (fix in this PR):
See westonruter/syntax-highlighting-code-block#193