Skip to content

Declare previous dynamic properties#102

Merged
allejo merged 1 commit into
scrivo:9.18from
phpfui:V9_PHP82
Dec 17, 2022
Merged

Declare previous dynamic properties#102
allejo merged 1 commit into
scrivo:9.18from
phpfui:V9_PHP82

Conversation

@phpfui

@phpfui phpfui commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

PHP 8.2 fix for V9

There may be some failed tests. I can't run versions of PHP from the late Ming Dynasty on my machine, but the code should be PHP 5 compatible.

Closes #99

@phpfui

phpfui commented Dec 17, 2022

Copy link
Copy Markdown
Contributor Author

Where are we at this this? Pretty much a no brainer to test and merge.

This is holding up upgrading one of my packages, as I don't want to introduce a depreciation warning to users of my package.

I also did the same fix for the main branch, but that seems to have issues highlighting the code correctly.

Thanks!

@allejo allejo merged commit aee2830 into scrivo:9.18 Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants