Conversation
@tjarvstrand needs it for the stuff he works on.
Contributor
Author
|
/cc @tjarvstrand |
Contributor
Author
|
I didn't bother bumping the version because #46 already takes care of that. |
arybczak
requested changes
Apr 4, 2019
Contributor
Author
|
@arybczak OK. Otherwise you're fine with the new dependency? |
Collaborator
Yeah, I think it's alright. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also since we're doing a major version bump anyway,
rename a bunch of modules to follow the more widespread naming conventions.Module renaming patches dropped after code review. See therename-modulesbranch if you're curious what was in those.