Skip to content

[v1.3] monaco editor hints 多国语言化 及 增加 @require-css 提示 #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CodFrm merged 8 commits into from
Dec 10, 2025
Merged

[v1.3] monaco editor hints 多国语言化 及 增加 @require-css 提示 #960

CodFrm merged 8 commits into from
Dec 10, 2025

Conversation

@cyfung1031
Copy link
Collaborator

@cyfung1031 cyfung1031 commented Nov 15, 2025 •
edited
Loading

@cyfung1031 cyfung1031 force-pushed the pr-meta--header-hint-001 branch from 7b594a4 to ff571dd Compare November 17, 2025 11:28
@cyfung1031 cyfung1031 changed the title monaco editor hints 多国语言化 monaco editor hints 多国语言化 及 增加 @require-css 提示 Nov 18, 2025
@CodFrm CodFrm changed the base branch from main to release/v1.3 November 20, 2025 07:26
@cyfung1031 cyfung1031 changed the title monaco editor hints 多国语言化 及 增加 @require-css 提示 [v1.3] monaco editor hints 多国语言化 及 增加 @require-css 提示 Nov 22, 2025
@cyfung1031 cyfung1031 force-pushed the pr-meta--header-hint-001 branch from d782d85 to 7c5597a Compare December 9, 2025 07:10
@cyfung1031
Copy link
Collaborator Author

cyfung1031 commented Dec 9, 2025 •
edited
Loading 

  messageQueue.subscribe<TKeyValue<SystemConfigKey>>(SystemConfigChange, ({ key, value }) => {
    if (key === "language") {
      // @ts-ignore
      updateLang(value);
    }
  });

@CodFrm 我不太懂你改过的 SystemConfigChange。有点复杂。
这部份的代码你再看看吧

@CodFrm
Copy link
Member

CodFrm commented Dec 9, 2025 

  messageQueue.subscribe<TKeyValue<SystemConfigKey>>(SystemConfigChange, ({ key, value }) => {
    if (key === "language") {
      // @ts-ignore
      updateLang(value);
    }
  });

@CodFrm 我不太懂你改过的 SystemConfigChange。有点复杂。 这部份的代码你再看看吧

我修改了

  systemConfig.addListener("language", (lang) => {
    updateLang(lang);
  });

@CodFrm CodFrm requested a review from Copilot December 9, 2025 07:24
@CodFrm CodFrm added the P1 🔥 重要但是不紧急的内容 label Dec 9, 2025
Copilot AI reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@CodFrm
Apply suggestions from code review
bbdc4cc 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@CodFrm CodFrm merged commit 51a6f94 into scriptscat:release/v1.3 Dec 10, 2025
1 of 3 checks passed
@cyfung1031 cyfung1031 deleted the pr-meta--header-hint-001 branch December 21, 2025 09:42
This was referenced Jan 9, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

P1 🔥 重要但是不紧急的内容

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Monaco Editor 对 @require-css 出现错误提示 [Feature] [i18n] src/pkg/utils/monaco-editor/index.ts

2 participants

@cyfung1031 @CodFrm