[release/v1.3] 调整 updateIcon 代码 #908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
这个 PR 重构了 updateIcon 方法，使其能够根据 isUserScriptsAvailable 和 isLoadScripts 两个状态自动判断应该显示哪个图标，而不再需要调用方传入参数。
主要变更：
- 将
updateIcon方法从接受enableUserscript参数改为无参数，内部自动计算状态 - 简化了方法实现，消除了重复的
chrome.action.setIcon调用 - 在适当的时机添加了
updateIcon()调用，确保图标状态正确更新
| console.error("chrome.runtime.lastError in chrome.action.setIcon:", lastError); | ||
| } | ||
| updateIcon() { | ||
| const enableUserscript: boolean = this.isUserScriptsAvailable && this.isLoadScripts; |
There was a problem hiding this comment.
[nitpick] 变量 enableUserscript 使用了不必要的显式类型注解。TypeScript 可以从右侧的布尔表达式自动推断类型为 boolean。建议移除 : boolean 以保持代码简洁，符合 TypeScript 最佳实践。
Suggested change
| const enableUserscript: boolean = this.isUserScriptsAvailable && this.isLoadScripts; | |
| const enableUserscript = this.isUserScriptsAvailable && this.isLoadScripts; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概述 Descriptions
关联的 commit 3e406dc
变更内容 Changes
截图 Screenshots