Don't use semaphores for blocking#3
Merged
scriptingosx merged 1 commit intoscriptingosx:mainfrom Jul 17, 2025
Merged
Conversation
Methods with completion handlers, like the ones used on NSWorkspace, get imported as async methods to Swift Concurrency. This requires updating command definitions to be async.
Owner
|
oh excellent catch, I have been dragging that code with the semaphores around for too long. Question: is there a reason you are declaring all commands as asynchronous in stead of just the few that actually call the methods you have changed to async? |
Owner
|
Ignore the question, you did answer that... |
Owner
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally, mixing semaphores and async is a risky proposition.
This PR changes every
ParsableCommandto be anAsyncParsableCommand, so they have arun() asyncmethod instead of arun()method. This means we can trivially replace the usages ofDispatchSemaphorewith the async versions that are created automatically by the compiler when importing closure-based methods. (Under the hood they use continuations)I decided to change every
ParsableCommandto be Async, even though it was only needed forManageandSet. This ensures consistency between command definitions and easier async adoption in future PRs.