Skip to content

Fix DateTime and Object tests #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xoofx merged 4 commits into from
Mar 6, 2025
Merged

Fix DateTime and Object tests #593

xoofx merged 4 commits into from
Mar 6, 2025

Conversation

@user-named-void
Copy link
Contributor

@user-named-void user-named-void commented Mar 5, 2025

A Doc_date test failed because it validates the date.now.year.

@xoofx
Copy link
Member

xoofx commented Mar 5, 2025

The doc is automatically generated from

scriban/src/Scriban/Functions/DateTimeFunctions.cs

Lines 123 to 134 in f8fa7e2

/// <summary>
/// Returns a datetime object of the current time, including the hour, minutes, seconds and milliseconds.
/// </summary>
/// <remarks>
/// ```scriban-html
/// {{ date.now.year }}
/// ```
/// ```html
/// 2024
/// ```
/// </remarks>
public static DateTime Now() => DateTime.Now;

You need then to rerun Scriban.DocGen to generate the associated file.

@user-named-void
Copy link
Contributor Author

user-named-void commented Mar 6, 2025

@xoofx thank you for pointing me in the right direction, the remarks are updated and if have ran Sriban.DocGen

@xoofx
Copy link
Member

xoofx commented Mar 6, 2025

Not your fault (probably a previous PR), but it seems the JSON version in the code is invalid and has invalid spaces:

scriban/src/Scriban/Functions/ObjectFunctions.cs

Lines 441 to 481 in f8fa7e2

/// <summary>
/// Converts the json to a scriban value. Object, Array, string, etc.
/// </summary>
/// <param name="context">The template context</param>
/// <param name="json">The json to deserialize.</param>
/// <returns>Returns the scriban value</returns>
/// <remarks>
/// ```scriban-html
/// {{
/// obj = `{ "foo": 123 }` | object.from_json
/// obj.foo
/// }}
/// ```
/// ```html
/// 123
/// ```
/// </remarks>
public static object FromJson(TemplateContext context, string json)
{
return JsonSerializer.Deserialize<JsonElement>(json).ToScriban();
}
/// <summary>
/// Converts the scriban value to JSON
/// </summary>
/// <param name="context">The template context</param>
/// <param name="value">The input object.</param>
/// <returns>A JSON representation of the value</returns>
/// <remarks>
/// ```scriban-html
/// {{ { foo: "bar", baz: [1, 2, 3] } | object.to_json }}
/// {{ true | object.to_json }}
/// {{ null | object.to_json }}
/// ```
/// ```html
/// { "foo": "bar", "baz": [1, 2, 3] }
/// true
/// null
/// ```
/// </remarks>
public static string ToJson(TemplateContext context, object value)

If you can correct it as well, that would be great, thank you!

@xoofx
Copy link
Member

xoofx commented Mar 6, 2025

Basically it should be:

 /// ```html 
 /// {"foo":"bar","baz":[1, 2, 3]} 
 /// true 
 /// null 
 /// ``` 
 /// </remarks> 
 public static string ToJson(TemplateContext context, object value)

@user-named-void user-named-void changed the title Doc_date test failed because of new year Fix DateTime and Object tests Mar 6, 2025
@user-named-void
Copy link
Contributor Author

user-named-void commented Mar 6, 2025

Yes, i fixed the object.to_json test, all test are now succesfull on my system

@xoofx xoofx added the bug label Mar 6, 2025
@xoofx xoofx merged commit 9140c2a into scriban:master Mar 6, 2025
1 check passed
@xoofx
Copy link
Member

xoofx commented Mar 6, 2025

Thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@user-named-void @xoofx