fix(store): scope "screenpipe" ignore-pattern to app name only#4019
Merged
louis030195 merged 2 commits intoJun 11, 2026
Merged
Conversation
Unscoped entry matched app name OR window title — browser tabs titled "screenpipe/screenpipe — GitHub" were falsely excluded and rendered black. "screenpipe::" scopes to app name only (self-capture still blocked). https://github.com/screenpipe/screenpipe/blob/main/crates/screenpipe-core/src/window_pattern.rs#L14-L21
… app-scoped Existing store.bin entries still carried the legacy "screenpipe" string. Patch it to "screenpipe::" on load so the fix applies to existing installs without requiring a manual settings reset. https://github.com/screenpipe/screenpipe/blob/main/crates/screenpipe-core/src/window_pattern.rs#L13-L22
divanshu-go
commented
Jun 11, 2026
Comment on lines
+1333
to
+1343
| // Migrate unscoped "screenpipe" ignore-pattern to app-scoped "screenpipe::" | ||
| // so browser tabs whose title contains "screenpipe" are no longer falsely | ||
| // excluded from SCK capture and rendered black. | ||
| if let Some(Value::Array(windows)) = obj.get_mut("ignoredWindows") { | ||
| for entry in windows.iter_mut() { | ||
| if entry.as_str() == Some("screenpipe") { | ||
| *entry = Value::String("screenpipe::".to_string()); | ||
| } | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
The migration block is there because the default fix alone only helps new installs — existing users already have the old value written to disk.
This patches it silently on next launch. No action needed from the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The default
ignored_windowslist contained the unscoped entry"screenpipe". Unscoped patterns match when the substring appears in either the app name or the window title. This caused any browser tab whose title contained "screenpipe" (e.g.screenpipe/screenpipe — GitHub) to be resolved as an excluded SCK window ID and rendered black in capture.Fix
Changed
"screenpipe"→"screenpipe::". The::scope syntax constrains the match to the app name only, leaving the title unchecked. The screenpipe app window is still excluded from self-capture; browser tabs are unaffected.Reference
screenpipe/crates/screenpipe-core/src/window_pattern.rs
Lines 13 to 22 in 55aa0e6
Before
After