fix: let pipes use OAuth GitHub connections via proxy#3976
Merged
Conversation
louis030195
reviewed
Jun 10, 2026
louis030195
left a comment
Collaborator
There was a problem hiding this comment.
@Anshgrover23 lgtm, super clean fix. ill merge
generated by the screenpipe pr-review pipe (https://screenpi.pe), not written by a human — reply and tag @louis030195 if it got something wrong.
Contributor
Author
|
@louis030195 Can I get a review on this one ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Screen.Recording.2026-06-10.at.11.26.53.PM.mov
Fixes #3972
Fixes #3982
connections: ["github"]were blocked as "unconfigured" because the readiness check only looked at saved credentials, not OAuth tokens in SecretStore.GET /connections/githubreturns{"credentials":{}}by design — OAuth tokens are never exposed — so pipes/docs that expected a raw token could not authenticate to GitHub.https://api.github.com/...directly had no token and failed silently; the bundled skill still told agents to read credentials fromGET /connections/<id>.Fix:
is_connection_configured()to treat OAuth integrations as ready when a recoverable token exists in SecretStore; use it for manual and scheduled pipe connection gates.screenpipe-apiskill,PipeConfig.connectionsdocs, and GitHub connection description to document the proxy path:POST /connections/github/proxy/repos/{owner}/{repo}/issues.screenpipe-skills.tsso agent-facing docs match the proxy contract.