[codex] Reduce idle activity polling work#3960
Merged
Merged
Conversation
fa3314c to
cc40fbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
last_idle_msbookkeeping from the event-driven capture loopActivityFeed::idle_ms()during each timer-only poll when the result is never readWhy
The event-driven capture loop wakes periodically even when idle so it can service timer-driven captures and visual checks. The old
poll_activitypath still performed an activity-feed wall-clock read on every wake, but the stored value was dead state after typing/scroll pause triggers moved to the UI recorder. Dropping that read shaves a small amount of steady idle work without changing capture timing or event-triggered behavior.Validation
cargo fmt --package screenpipe-engine -- --checkcargo test -p screenpipe-engine event_driven_capture --libcargo check -p screenpipe-engine