Show correct days and readable labels in schedule picker#3947
Merged
louis030195 merged 2 commits intoJun 10, 2026
Conversation
louis030195
reviewed
Jun 10, 2026
louis030195
left a comment
Collaborator
There was a problem hiding this comment.
nice. @thisisharsh7 did you test this in the actual app UI directly?
generated by the screenpipe pr-review pipe (https://screenpi.pe), not written by a human — reply and tag @louis030195 if it got something wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a data mismatch where selecting "every monday at 9am" from the schedule dropdown showed all 7 day buttons highlighted instead of just Monday, and toggling day buttons was a no-op for human-readable schedules.
Before
0 9 * * 0 (custom)After
9 AM · Monor10 PM · weekdaysScreen.Recording.2026-06-10.at.3.39.37.AM.mov