Fix mid-text click in meeting notes and chat selection#3926
Merged
louis030195 merged 1 commit intoJun 9, 2026
Conversation
louis030195
reviewed
Jun 9, 2026
louis030195
left a comment
Collaborator
There was a problem hiding this comment.
apps/screenpipe-app-tauri/app/layout.tsx:323 — did you test this with markdown/prose editors too? @thisisharsh7
generated by the screenpipe pr-review pipe (https://screenpi.pe), not written by a human — reply and tag @louis030195 if it got something wrong.
Contributor
Author
|
yes this is where the bug was found. tested cursor placement and drag selection mid-sentence in the meeting notes editor and chat assistant messages. Both work correctly now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes cursor placement and text selection being broken when clicking mid-sentence across the app in meeting notes editor, chat messages, and any
.proseorcontenteditablearea.The cursor would jump to the end of the line instead of landing where you clicked, and drag-selection from mid-sentence didn't work either.
Root cause: the
selectstarthandler inlayout.tsxassumede.targetis always an Element, but mid-text clicks produce Text nodes which lack.closest(), sopreventDefault()fired and blocked all mid-text selections.Fixed by walking up to the parent Element for Text nodes before checking
.closest()fixes #3906
fixes #3772
Screen.Recording.2026-06-09.at.9.02.31.AM.mov
Screen.Recording.2026-06-09.at.9.04.25.AM.mov