fix(audio): actionable errors when a corporate network blocks model downloads#3920
Merged
Merged
Conversation
…by a corporate network Closes #3655. Model downloads (pyannote speaker segmentation/embedding) fail opaquely on corporate networks that do TLS interception, require a proxy, or sit behind a captive portal. The raw reqwest error ("error sending request", "invalid peer certificate: UnknownIssuer") tells the user nothing about what to do. Classify the common failure modes and attach an actionable hint: - TLS cert rejected: MITM proxy, trust the corp root cert - DNS lookup failed: network/VPN/DNS - connection refused/reset/unreachable: firewall/proxy - timeout: proxy throttling - HTTP 407/401/403/511 and unexpected redirects: proxy auth / captive portal - 200 OK with text/html body: captive portal serving a login page, not the model The string matcher is split into a pure classify_download_failure helper with a unit test (reqwest::Error has no public constructor, so the typed timeout check stays in the thin wrapper). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.