feat(settings): add searchable settings#3910
Merged
Merged
Conversation
louis030195
reviewed
Jun 8, 2026
louis030195
left a comment
Collaborator
There was a problem hiding this comment.
nice feature! @Anshgrover23 does this work well on windows / linux as well?
apps/screenpipe-app-tauri/components/settings/settings-search.tsx:18 — why inline import for fuse options type?
apps/screenpipe-app-tauri/components/settings/settings-search.tsx:286 — why monkey patch the dom node for the timer?
generated by the screenpipe pr-review pipe (https://screenpi.pe), not written by a human — reply and tag @louis030195 if it got something wrong.
Contributor
Author
|
@louis030195 Can I get a review on this one ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #3907
Screen.Recording.2026-06-09.at.1.05.54.AM.mov
Screen.Recording.2026-06-09.at.1.10.26.AM.mov
results without unmounting the nav.
central registry), powered by Fuse.js (threshold 0.4) with a substring fast-path for deterministic prefix ranking.