chore(workspace): consolidate all shared dependencies#3815
Conversation
b0aa01b to
aa70503
Compare
louis030195
left a comment
There was a problem hiding this comment.
@divanshu-go very nice cleanup, makes workspace much easier to maintain
.github/workflows/style.yml:67 — cargo install cargo-consolidate is slow in ci, maybe use cargo-binstall or cache?
generated by the screenpipe pr-review pipe (https://screenpi.pe), not written by a human — reply and tag @louis030195 if it got something wrong.
| - name: Install cargo-audit | ||
| run: cargo install cargo-audit | ||
| - name: Install cargo tools | ||
| uses: taiki-e/install-action@v2 | ||
| with: | ||
| tool: cargo-audit,cargo-deny,cargo-consolidate |
There was a problem hiding this comment.
Time reduced by 4 min
dbea500 to
fe29948
Compare
|
@divanshu-go can ufix conflict didy ou run the app with all those dependencies change and it work properly? |
louis030195
left a comment
There was a problem hiding this comment.
lgtm, love taiki-e action. @divanshu-go does this compile on windows/linux? workspace dep changes sometimes break cross-platform builds
generated by the screenpipe pr-review pipe (https://screenpi.pe), not written by a human — reply and tag @louis030195 if it got something wrong.
|
@divanshu-go can you fix conflicts? a |
fe29948 to
5ae90cc
Compare
|
@louis030195 Resolved all the conflicts. |
Move hardcoded version strings for common deps (serde, anyhow, chrono,
tokio, sqlx, ort, dirs, rand, etc.) into [workspace.dependencies] in
the root Cargo.toml and the ee/sdk sub-workspace. Individual crates now
use `{ workspace = true }` so versions are pinned in one place.
Also updates style.yml to install cargo-consolidate via taiki-e and run
`cargo consolidate` as a CI check.
…, zbus, image Add `default-features = false` to workspace entries for ort, tokenizers, and zbus so per-crate `default-features = false` overrides are respected. Remove the redundant `default-features = false` from screenpipe-rfdetr-mlx's image dep (workspace default is fine there; the per-crate flag was already being ignored).
a03ed95 to
70432ca
Compare
Summary
Moves every repeated dependency across 19 workspace crates to
[workspace.dependencies]in rootCargo.toml— versions are now declared once, crates use{ workspace = true }Adds
cargo consolidatestep to theoptimizeCI job instyle.yml