add "self" parameter for middlewares.py.tmpl#2882
Closed
BruceDone wants to merge 1 commit intoscrapy:1.3from
Closed
add "self" parameter for middlewares.py.tmpl#2882BruceDone wants to merge 1 commit intoscrapy:1.3from
BruceDone wants to merge 1 commit intoscrapy:1.3from
Conversation
fix the startproject command generate the wrong middleware for project
Member
|
Hey @BruceDone, this issue is fixed in the current 1.4 release by #2595; any particular reason you want it in 1.3? Is upgrading an option? |
Author
|
Hi @kmike , thanks for your quick response , since i use the pip to install this version of package , it seems we should always supply the right package for user to install , since the current version has already fixed it , feel free to close this pr :) |
Member
|
Thanks for the pull request @BruceDone, even though it is not merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the startproject command generate the wrong middleware for project