Skip to content

Stabilize tests at midnight#542

Closed
orivej wants to merge 2 commits intoscrapinghub:masterfrom
orivej:midnight
Closed

Stabilize tests at midnight#542
orivej wants to merge 2 commits intoscrapinghub:masterfrom
orivej:midnight

Conversation

@orivej
Copy link
Copy Markdown
Contributor

@orivej orivej commented Jul 21, 2019

Ensure that tests that compare times around now use identical now.

I was running the tests at midnight and noticed some failures.

@orivej
Stabilize tests at midnight
a421daf 
Ensure that tests that compare times around now use identical now.
@orivej
Copy link
Copy Markdown
Contributor Author

orivej commented Jul 21, 2019 •
edited
Loading

Even though this change seems useful, it turned out not to fix my original issue: when TZ environment variable is set to a value not supported by pytz/tzlocal but supported by libc/Python, such as TZ=NZT, dateparser miscalculates dates.

Gallaecio
Gallaecio reviewed Apr 28, 2020
View reviewed changes
Gallaecio
Gallaecio approved these changes May 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Gallaecio Gallaecio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failure seems unrelated to your changes, so ✔️. Mind the recent conflict, though.

@serhii73 serhii73 requested review from serhii73 and wRAR November 17, 2022 08:36
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 17, 2022 •
edited
Loading

Codecov Report

Base: 98.23% // Head: 95.01% // Decreases project coverage by -3.22% ⚠️

Coverage data is based on head (a421daf) compared to base (0f5d9c5).
Patch has no changes to coverable lines.

❗ Current head a421daf differs from pull request most recent head b3c6172. Consider uploading reports for the commit b3c6172 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
- Coverage   98.23%   95.01%   -3.23%     
==========================================
  Files         232      302      +70     
  Lines        2604     2466     -138     
==========================================
- Hits         2558     2343     -215     
- Misses         46      123      +77
Impacted Files Coverage Δ
dateparser/search/detection.py 94.23% <0.00%> (-3.73%) ⬇️
dateparser/date.py 97.91% <0.00%> (-1.37%) ⬇️
dateparser/parser.py 98.03% <0.00%> (-0.99%) ⬇️
dateparser/languages/dictionary.py 99.31% <0.00%> (-0.69%) ⬇️
dateparser/calendars/__init__.py 95.06% <0.00%> (-0.45%) ⬇️
dateparser/languages/validation.py 93.43% <0.00%> (-0.41%) ⬇️
dateparser/timezone_parser.py 97.91% <0.00%> (-0.30%) ⬇️
dateparser/freshness_date_parser.py 98.94% <0.00%> (-0.08%) ⬇️
dateparser/languages/locale.py 98.64% <0.00%> (-0.05%) ⬇️
dateparser/search/search.py 99.35% <0.00%> (-0.03%) ⬇️
... and 294 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

wRAR
wRAR reviewed Nov 17, 2022
View reviewed changes
tests/test_search.py
@@ -1,3 +1,5 @@
# -*- coding: utf-8 -*-
from __future__ import unicode_literals
Copy link
Copy Markdown
Member

@wRAR wRAR Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without Python 2 support this line is not needed.

@serhii73 serhii73 mentioned this pull request Dec 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wRAR wRAR wRAR left review comments

@serhii73 serhii73 Awaiting requested review from serhii73

+1 more reviewer

@Gallaecio Gallaecio Gallaecio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@orivej @wRAR @Gallaecio @serhii73