use current year in test_search_dates_with_prepositions#1294
Merged
Gallaecio merged 1 commit intoscrapinghub:masterfrom Jan 7, 2026
Merged
use current year in test_search_dates_with_prepositions#1294Gallaecio merged 1 commit intoscrapinghub:masterfrom
Gallaecio merged 1 commit intoscrapinghub:masterfrom
Conversation
Gallaecio
approved these changes
Jan 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1294 +/- ##
=======================================
Coverage 96.60% 96.60%
=======================================
Files 235 235
Lines 2886 2886
=======================================
Hits 2788 2788
Misses 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bmwiedemann
approved these changes
Jan 2, 2026
bmwiedemann
left a comment
There was a problem hiding this comment.
I tested that this fixes the test, even when running in year 2042.
Merged
Contributor
|
Closing and reopening so that the CI runs with #1296. |
Contributor
|
Thanks! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the year is not specified, the current year is used. We discovered the test failure today.
Fixes #1286.